From 82b86f9c4a8ec5623cabef91043c51bc078a6b34 Mon Sep 17 00:00:00 2001
From: patacongo <patacongo@42af7a65-404d-4744-a932-0658087f49c3>
Date: Sat, 23 Mar 2013 19:06:40 +0000
Subject: [PATCH] binfmt_execmodule() calls to sched_releasttcb() was not
 updated to use the second, thread type parameter

git-svn-id: svn://svn.code.sf.net/p/nuttx/code/trunk@5779 42af7a65-404d-4744-a932-0658087f49c3
---
 ChangeLog                                  | 8 +++++++-
 binfmt/binfmt_execmodule.c                 | 4 ++--
 configs/open1788/knsh/defconfig            | 3 +--
 configs/open1788/nsh/defconfig             | 3 +--
 configs/open1788/scripts/memory.ld         | 3 ++-
 configs/sam3u-ek/scripts/memory.ld         | 3 ++-
 configs/stm32f4discovery/scripts/memory.ld | 3 ++-
 7 files changed, 17 insertions(+), 10 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 1a855db641..a54bd46b86 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -4434,4 +4434,10 @@
 	  in the kernel build.  The original implementation was C-based
 	  and simpler.  However, the C code intermixed with SVC calls was
 	  not properly preserving registers.  The more complex, assembly
-	  language version does not suffer from these issues  (2013-03-23).
+	  language version does not suffer from these issues.  I believe
+	  the the kernel build can not be called "feature complete"
+	  (2013-03-23).
+	* binfmt/binfmt_execmodule.c:  Here is a place where I forget
+	  to update the call to sched_releasetcb() to pass the thread
+	  type as the second parameter (2013-03-23).
+
diff --git a/binfmt/binfmt_execmodule.c b/binfmt/binfmt_execmodule.c
index 651960267c..c984903599 100644
--- a/binfmt/binfmt_execmodule.c
+++ b/binfmt/binfmt_execmodule.c
@@ -245,10 +245,10 @@ int exec_module(FAR const struct binary_s *binp)
 errout_with_stack:
 #ifndef CONFIG_CUSTOM_STACK
   tcb->cmn.stack_alloc_ptr = NULL;
-  sched_releasetcb(&tcb->cmn);
+  sched_releasetcb(&tcb->cmn, TCB_FLAG_TTYPE_TASK);
   kufree(stack);
 #else
-  sched_releasetcb(&tcb->cmn);
+  sched_releasetcb(&tcb->cmn, TCB_FLAG_TTYPE_TASK);
 #endif
   goto errout;
 
diff --git a/configs/open1788/knsh/defconfig b/configs/open1788/knsh/defconfig
index addfd82ada..291740f8e2 100755
--- a/configs/open1788/knsh/defconfig
+++ b/configs/open1788/knsh/defconfig
@@ -191,8 +191,7 @@ CONFIG_LPC17_GPDMA=y
 #
 # SDIO Configuration
 #
-# CONFIG_SDIO_DMA=y
-CONFIG_SDIO_DMAPRIO=0x0
+# CONFIG_SDIO_DMA is not defined
 # CONFIG_SDIO_WIDTH_D1_ONLY is not set
 
 #
diff --git a/configs/open1788/nsh/defconfig b/configs/open1788/nsh/defconfig
index d4139111ab..27ae858294 100644
--- a/configs/open1788/nsh/defconfig
+++ b/configs/open1788/nsh/defconfig
@@ -185,8 +185,7 @@ CONFIG_LPC17_GPDMA=y
 #
 # SDIO Configuration
 #
-# CONFIG_SDIO_DMA=y
-CONFIG_SDIO_DMAPRIO=0x0
+# CONFIG_SDIO_DMA is not defined
 # CONFIG_SDIO_WIDTH_D1_ONLY is not set
 
 #
diff --git a/configs/open1788/scripts/memory.ld b/configs/open1788/scripts/memory.ld
index 690c7d3d62..33f93a195e 100644
--- a/configs/open1788/scripts/memory.ld
+++ b/configs/open1788/scripts/memory.ld
@@ -57,7 +57,8 @@
  *
  * For the same reasons, the maximum size of the SRAM mapping is limited to
  * 4KB.  Both of these alignment limitations could be reduced by using
- * multiple regions to map the FLASH/SDRAM range.
+ * multiple regions to map the FLASH/SDRAM range or perhaps with some
+ * clever use of subregions.
  *
  * A detailed memory map for the 64KB CPU SRAM region is as follows:
  *
diff --git a/configs/sam3u-ek/scripts/memory.ld b/configs/sam3u-ek/scripts/memory.ld
index 43fca9478f..c99a311465 100644
--- a/configs/sam3u-ek/scripts/memory.ld
+++ b/configs/sam3u-ek/scripts/memory.ld
@@ -58,7 +58,8 @@
  *
  * For the same reasons, the maximum size of the SRAM mapping is limited to
  * 4KB.  Both of these alignment limitations could be reduced by using
- * multiple regions to map the FLASH/SDRAM range.
+ * multiple regions to map the FLASH/SDRAM range or perhaps with some
+ * clever use of subregions.
  *
  * A detailed memory map for the 16Kb SRAM region is as follows:
  *
diff --git a/configs/stm32f4discovery/scripts/memory.ld b/configs/stm32f4discovery/scripts/memory.ld
index 0cf99ef967..ffe8054dba 100644
--- a/configs/stm32f4discovery/scripts/memory.ld
+++ b/configs/stm32f4discovery/scripts/memory.ld
@@ -65,7 +65,8 @@
  *
  * For the same reasons, the maximum size of the SRAM mapping is limited to
  * 4KB.  Both of these alignment limitations could be reduced by using
- * multiple regions to map the FLASH/SDRAM range.
+ * multiple regions to map the FLASH/SDRAM range or perhaps with some
+ * clever use of subregions.
  *
  * A detailed memory map for the 112KB SRAM region is as follows:
  *