nuttx/nuttx-update
1
2
Fork 1
Code Issues 1 Pull requests 1 Projects Releases Packages Wiki Activity Actions

stm32/stm32_adc.c: protect irq_attach with refcounter

Browse source 
irq_attach should only be called once for ADCs that share a common interrupt handler.
We can move irq_attach to just before interrupts are enabled.
This commit is contained in:
raiden00pl 2023-11-13 17:24:10 +01:00 committed by Alan Carvalho de Assis
parent 225d5bba6e
commit 0e40cc2853
1 changed files with 10 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
arch/arm/src/stm32/stm32_adc.c
View file

@ -2890,17 +2890,6 @@ static int adc_setup(struct adc_dev_s *dev)
return OK;
}
/* Attach the ADC interrupt */
#ifndef CONFIG_STM32_ADC_NOIRQ
ret = irq_attach(priv->irq, priv->isr, NULL);
if (ret < 0)
{
ainfo("irq_attach failed: %d\n", ret);
return ret;
}
#endif
/* Make sure that the ADC device is in the powered up, reset state */
adc_reset(dev);
@ -2954,9 +2943,18 @@ static int adc_setup(struct adc_dev_s *dev)
if (priv->cmn->refcount == 0)
#endif
{
#ifndef CONFIG_STM32_ADC_NOIRQ
/* Attach the ADC interrupt */
ret = irq_attach(priv->irq, priv->isr, NULL);
if (ret < 0)
{
ainfo("irq_attach failed: %d\n", ret);
return ret;
}
/* Enable the ADC interrupt */
#ifndef CONFIG_STM32_ADC_NOIRQ
ainfo("Enable the ADC interrupt: irq=%d\n", priv->irq);
up_enable_irq(priv->irq);
#endif