nuttx/nuttx-update
1
2
Fork 1
Code Issues 1 Pull requests 1 Projects Releases Packages Wiki Activity Actions

sched/semaphore/sem_holder.c: Remove DEBUGPANIC

Browse source 
There is a DEBUGPANIC in some logic.  This happens if a a task exists at certain points with priority inheritance enabled.  This event was not expected in the original design (although logic was provided to support it).  Since, apparently, it does happen, the DEBUGPANIC must be removed.

Noted by Brennan Ashton.
This commit is contained in:
Gregory Nutt 2020-05-04 07:42:04 -06:00 committed by Brennan Ashton
parent 8110ea6a7a
commit 2d4a8768c7
1 changed files with 8 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
sched/semaphore/sem_holder.c
View file

@ -115,6 +115,11 @@ static inline FAR struct semholder_s *nxsem_allocholder(sem_t *sem)
/****************************************************************************
* Name: nxsem_findholder
*
* NOTE: htcb may be used only as a look-up key. It certain cases, the task
* may have exited and htcb may refer to a stale memory. It must not be
* dereferenced.
*
****************************************************************************/
static FAR struct semholder_s *nxsem_findholder(sem_t *sem,
@ -323,10 +328,7 @@ static int nxsem_boostholderprio(FAR struct semholder_s *pholder,
if (!sched_verifytcb(htcb))
{
#if 0 /* DSA: sometimes crashes when Telnet calls external cmd (i.e. 'i2c') */
serr("ERROR: TCB 0x%08x is a stale handle, counts lost\n", htcb);
DEBUGPANIC();
#endif
swarn("WARNING: TCB 0x%08x is a stale handle, counts lost\n", htcb);
nxsem_freeholder(sem, pholder);
}
@ -490,8 +492,8 @@ static int nxsem_restoreholderprio(FAR struct tcb_s *htcb,
if (!sched_verifytcb(htcb))
{
serr("ERROR: TCB 0x%08x is a stale handle, counts lost\n", htcb);
DEBUGPANIC();
swarn("WARNING: TCB 0x%08x is a stale handle, counts lost\n", htcb);
pholder = nxsem_findholder(sem, htcb);
if (pholder != NULL)
{