nuttx/nuttx-update
1
2
Fork 1
Code Issues 1 Pull requests 1 Projects Releases Packages Wiki Activity Actions

Fix Overlap Handling in sim_copyfullstate to Prevent Undefined Behavior

Browse source
This commit is contained in:
Ritvik 2025-01-04 12:16:42 -05:00 committed by archer
parent 4d63921f0a
commit 3e6649856b
1 changed files with 2 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
arch/sim/src/sim/sim_copyfullstate.c
View file

@ -27,6 +27,7 @@
#include <nuttx/config.h> #include <nuttx/config.h>
#include <stdint.h> #include <stdint.h>
#include <string.h>
#include <arch/irq.h> #include <arch/irq.h>
#include "sim_internal.h" #include "sim_internal.h"
@ -45,8 +46,6 @@
void sim_copyfullstate(xcpt_reg_t *dest, xcpt_reg_t *src) void sim_copyfullstate(xcpt_reg_t *dest, xcpt_reg_t *src)
{ {
int i;
/* In the sim model, the state is copied from the stack to the TCB, /* In the sim model, the state is copied from the stack to the TCB,
* but only a reference is passed to get the state from the TCB. So the * but only a reference is passed to get the state from the TCB. So the
* following check avoids copying the TCB save area onto itself: * following check avoids copying the TCB save area onto itself:
@ -54,9 +53,6 @@ void sim_copyfullstate(xcpt_reg_t *dest, xcpt_reg_t *src)
if (src != dest) if (src != dest)
{ {
for (i = 0; i < XCPTCONTEXT_REGS; i++) memmove(dest, src, XCPTCONTEXT_REGS * sizeof(xcpt_reg_t));
{
*dest++ = *src++;
}
} }
} }