nuttx/nuttx-update
1
2
Fork 1
Code Issues 1 Pull requests 1 Projects Releases Packages Wiki Activity Actions

syslog: Remove SYSLOG_SERIAL_CONSOLE which isn't really used

Browse source
This commit is contained in:
Xiang Xiao 2020-02-19 10:45:56 +08:00 committed by Gregory Nutt
parent fdf673c5c7
commit 553f12b4e8
4 changed files with 5 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
Documentation/NuttxPortingGuide.html
View file

@ -6716,7 +6716,7 @@ int syslog_initialize(void);
<ol>
<li>
<p><b>Low-Level Serial Output</b>.
If you are using a SYSLOG console channel (<code>CONFIG_SYSLOG_CONSOLE</code>) with a serial console (<code>CONFIG_SYSLOG_SERIAL_CONSOLE</code>) and if the underlying architecture supports the low-level <code>up_putc()</code> interface(<code>CONFIG_ARCH_LOWPUTC</code>), then the SYLOG logic will direct the output to <code>up_putc()</code> which is capable of generating the serial output within the context of an interrupt handler.
If you are using a SYSLOG console channel (<code>CONFIG_SYSLOG_CONSOLE</code>) and if the underlying architecture supports the low-level <code>up_putc()</code> interface(<code>CONFIG_ARCH_LOWPUTC</code>), then the SYLOG logic will direct the output to <code>up_putc()</code> which is capable of generating the serial output within the context of an interrupt handler.
</p>
<p>
There are a few issues in doing this however:
@ -6781,16 +6781,12 @@ int syslog_initialize(void);
</li>
<li>
<p>
<code>CONFIG_SYSLOG_CONSOLE</code>. This configuration option is manually selected from the SYSLOG menu. This is the option that actually enables the SYSLOG console device. It depends on <code>CONFIG_DEV_CONSOLE</code> and it will automatically select <code>CONFIG_SYSLOG_SERIAL_CONSOLE</code> if <code>CONFIG_SERIAL_CONSOLE</code> is selected.
<code>CONFIG_SYSLOG_CONSOLE</code>. This configuration option is manually selected from the SYSLOG menu. This is the option that actually enables the SYSLOG console device. It depends on <code>CONFIG_DEV_CONSOLE</code>.
</li>
<li>
<p>
<code>CONFIG_ARCH_LOWPUTC</code>. This is an indication from the architecture configuration that the platform supports the <code>up_putc()</code> interface. <code>up_putc()</code> is a very low level UART interface that can even be used from interrupt handling.
</li>
<li>
<p>
<code>CONFIG_SYSLOG_SERIAL_CONSOLE</code>. This enables certain features of the SYSLOG operation that depend on a serial console. If <code>CONFIG_ARCH_LOWPUTC</code> is also selected, for example, then <code>up_putc()</code> will be used for the forced SYSLOG output.
</li>
</ul>
<p>
Interrupt level SYSLOG output will be lost unless: (1) the interrupt buffer

1
boards/arm/samv7/samv71-xult/README.txt
View file

@ -1902,7 +1902,6 @@ Configuration sub-directories
following in the .config file:
CONFIG_SYSLOG_CONSOLE=y
CONFIG_SYSLOG_SERIAL_CONSOLE=y
7. Telnet: The clicker2-stm32 star point configuration supports the
Telnet daemon, but not the Telnet client; the star hub configuration

5
drivers/syslog/Kconfig
View file

@ -126,10 +126,6 @@ config SYSLOG_PREFIX_STRING
---help---
The prefix string to be prepend.
config SYSLOG_SERIAL_CONSOLE
bool
default n
choice
prompt "System log device"
default SYSLOG_CONSOLE if DEV_CONSOLE
@ -156,7 +152,6 @@ config RAMLOG_SYSLOG
config SYSLOG_CONSOLE
bool "Log to /dev/console"
depends on DEV_CONSOLE
select SYSLOG_SERIAL_CONSOLE if SERIAL_CONSOLE
select SYSLOG_WRITE
---help---
Use the system console as a SYSLOG output device.

13
drivers/syslog/README.txt
View file

@ -235,9 +235,8 @@ SYSLOG Channels
1. Low-Level Serial Output
--------------------------
If you are using a SYSLOG console channel (CONFIG_SYSLOG_CONSOLE) with a
serial console (CONFIG_SYSLOG_SERIAL_CONSOLE) and if the underlying
architecture supports the low-level up_putc() interface
If you are using a SYSLOG console channel (CONFIG_SYSLOG_CONSOLE) and if
the underlying architecture supports the low-level up_putc() interface
(CONFIG_ARCH_LOWPUTC), then the SYSLOG logic will direct the output to
up_putc() which is capable of generating the serial output within the
context of an interrupt handler.
@ -301,17 +300,11 @@ SYSLOG Channel Options
There is no user selection.
* CONFIG_SYSLOG_CONSOLE. This configuration option is manually selected
from the SYSLOG menu. This is the option that acutally enables the
SYSLOG console device. It depends on CONFIG_DEV_CONSOLE and it will
automatically select CONFIG_SYSLOG_SERIAL_CONSOLE if
CONFIG_SERIAL_CONSOLE is selected.
SYSLOG console device. It depends on CONFIG_DEV_CONSOLE.
* CONFIG_ARCH_LOWPUTC. This is an indication from the architecture
configuration that the platform supports the up_putc() interface.
up_putc() is a very low level UART interface that can even be used from
interrupt handling.
* CONFIG_SYSLOG_SERIAL_CONSOLE. This enables certain features of the
SYSLOG operation that depend on a serial console. If
CONFIG_ARCH_LOWPUTC is also selected, for example, then up_putc() will
be used for the forced SYSLOG output.
Interrupt level SYSLOG output will be lost unless: (1) the interrupt buffer
is enabled to support serialization, or (2) a serial console is used and