nuttx/nuttx-update
1
2
Fork 1
Code Issues 1 Pull requests 1 Projects Releases Packages Wiki Activity Actions

ROMFS: stat() and fstat() should always indicate that directories are executable.

Browse source
This commit is contained in:
Gregory Nutt 2017-02-13 16:56:55 -06:00
parent d677e63008
commit 78fa87c7db
1 changed files with 5 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
fs/romfs/fs_romfs.c
View file

@ -1184,13 +1184,10 @@ static int romfs_stat_common(uint8_t type, uint32_t size,
memset(buf, 0, sizeof(struct stat));
if (IS_DIRECTORY(type))
{
/* It's a read-only directory name */
/* It's a read-execute directory name */
buf->st_mode = S_IFDIR | S_IROTH | S_IRGRP | S_IRUSR;
if (IS_EXECUTABLE(type))
{
buf->st_mode |= S_IXOTH | S_IXGRP | S_IXUSR;
}
buf->st_mode = S_IFDIR | S_IROTH | S_IXOTH | S_IRGRP | S_IXGRP |
S_IRUSR | S_IXUSR;
}
else if (IS_FILE(type))
{
@ -1199,6 +1196,8 @@ static int romfs_stat_common(uint8_t type, uint32_t size,
buf->st_mode = S_IFREG | S_IROTH | S_IRGRP | S_IRUSR;
if (IS_EXECUTABLE(type))
{
/* It's a read-execute file name */
buf->st_mode |= S_IXOTH | S_IXGRP | S_IXUSR;
}
}