Add kill()

git-svn-id: svn://svn.code.sf.net/p/nuttx/code/trunk@108 42af7a65-404d-4744-a932-0658087f49c3

ChangeLog

@@ -64,6 +64,7 @@
 	  POSIX compliance.
 	* Eliminate compilation warnings that that crept into
 	  recent check-ins
+	* Add kill()
 	* Some Documentation updates
 	* Added support for the Neuros OSD / DM320
 

include/signal.h

@@ -83,10 +83,6 @@
                            * with 3 args instead of 1
                            * (always assumed) */
 
-/* Dummy value for the sigev_notify field of struct sigevent */
-
-#define SIGEV_SIGNAL    0
-
 /* These are the possible values of the signfo si_code field */
 
 #define SI_USER         0 /* Signal sent from kill, raise, or abort */
@@ -96,7 +92,7 @@
 #define SI_MESGQ        4 /* Signal generated by arrival of a message on an */
                           /* empty message queue */
 
-/* sigevent definitions */
+/* Values for the sigev_notify field of struct sigevent */
 
 #define SIGEV_NONE      0 /* No notification desired */
 #define SIGEV_SIGNAL    1 /* Notify via signal */

sched/Makefile

@@ -61,7 +61,7 @@ CLOCK_SRCS	= clock_initialize.c mktime.c gmtime_r.c clock_settime.c \
 		  clock_gettime.c clock_getres.c
 SIGNAL_SRCS	= sig_initialize.c \
 		  sig_action.c sig_procmask.c sig_pending.c sig_suspend.c \
-		  sig_queue.c sig_waitinfo.c sig_timedwait.c \
+		  sig_kill.c sig_queue.c sig_waitinfo.c sig_timedwait.c \
 		  sig_emptyset.c sig_fillset.c sig_addset.c sig_delset.c \
 		  sig_ismember.c sig_findaction.c \
 		  sig_allocatependingsigaction.c sig_releasependingsigaction.c \

sched/sig_kill.c

@@ -0,0 +1,134 @@
+/************************************************************
+ * sig_kill.c
+ *
+ *   Copyright (C) 2007 Gregory Nutt. All rights reserved.
+ *   Author: Gregory Nutt <spudmonkey@racsa.co.cr>
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright
+ *    notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in
+ *    the documentation and/or other materials provided with the
+ *    distribution.
+ * 3. Neither the name Gregory Nutt nor the names of its contributors may be
+ *    used to endorse or promote products derived from this software
+ *    without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
+ * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
+ * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
+ * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
+ * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
+ * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
+ * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
+ * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ *
+ ************************************************************/
+
+/************************************************************
+ * Included Files
+ ************************************************************/
+
+#include <nuttx/config.h>
+#include <sched.h>
+#include <errno.h>
+#include <debug.h>
+#include "os_internal.h"
+#include "sig_internal.h"
+
+/************************************************************
+ * Global Functions
+ ************************************************************/
+
+/************************************************************
+ * Function:  kill
+ *
+ * Description:
+ *   The kill() system call can be used to send any signal to
+ *   any task.
+ *
+ *   Limitation: Sending of signals to 'process groups' is
+ *   not supported in NuttX
+ *
+ * Parameters:
+ *   pid - The id of the task to receive the signal.  The
+ *     POSIX kill specification encodes process group
+ *     information as zero and negative pid values.  Only
+ *     positive, non-zero values of pid are supported by this
+ *     implementation.
+ *   signo - The signal number to send.
+ *
+ * Return Value:
+ *    On  success (at least one signal was sent), zero is
+ *    returned.  On error, -1 is returned, and errno is set
+ *    appropriately.
+ *
+ *    EINVAL An invalid signal was specified.
+ *    EPERM  The process does not have permission to send the
+ *           signal to any of the target processes.
+ *    ESRCH  The pid or process group does not exist.
+ *    ENOSYS Do not support sending signals to process groups.
+ *
+ * Assumptions:
+ *
+ ************************************************************/
+
+int kill(pid_t pid, int signo)
+{
+  FAR _TCB *stcb;
+  siginfo_t info;
+  int       ret = ERROR;
+
+  /* We do not support sending signals to process groups */
+
+  if (pid <= 0)
+    {
+      *get_errno_ptr() = ENOSYS;
+      return ERROR;
+    }
+
+  /* Make sure that the signal is valid */
+
+  if (!GOOD_SIGNO(signo))
+    {
+      *get_errno_ptr() = EINVAL;
+      return ERROR;
+    }
+
+  /* Keep things stationary through the following */
+
+  sched_lock();
+
+  /* Get the TCB of the receiving task */
+
+  stcb = sched_gettcb(pid);
+  dbg("TCB=0x%08x signo=%d\n", stcb, signo);
+  if (!stcb)
+    {
+      *get_errno_ptr() = ESRCH;
+      sched_unlock();
+      return ERROR;
+    }
+
+  /* Create the siginfo structure */
+
+  info.si_signo           = signo;
+  info.si_code            = SI_USER;
+  info.si_value.sival_ptr = NULL;
+
+  /* Send the signal */
+
+  ret = sig_received(stcb, &info);
+  sched_unlock();
+  return ret;
+}
+
+

sched/sig_queue.c

@@ -43,6 +43,7 @@
 #include <signal.h>
 #include <debug.h>
 #include <sched.h>
+#include <errno.h>
 #include "os_internal.h"
 #include "sig_internal.h"
 
@@ -92,7 +93,15 @@
  *   value - Value to pass to task with signal
  *
  * Return Value:
- *   None
+ *    On  success (at least one signal was sent), zero is
+ *    returned.  On error, -1 is returned, and errno is set
+ *    appropriately.
+ *
+ *    EGAIN The limit of signals which may be queued has been reached.
+ *    EINVAL sig was invalid.
+ *    EPERM  The  process  does  not  have  permission to send the
+ *      signal to the receiving process.
+ *    ESRCH  No process has a PID matching pid.
  *
  * Assumptions:
  *
@@ -108,6 +117,14 @@ int sigqueue(int pid, int signo, void *sival_ptr)
   siginfo_t info;
   int       ret = ERROR;
 
+  /* sanity checks */
+
+  if (!GOOD_SIGNO(signo))
+    {
+      *get_errno_ptr() = EINVAL;
+      return ERROR;
+    }
+
   sched_lock();
 
   /* Get the TCB of the receiving task */
@@ -118,6 +135,12 @@ int sigqueue(int pid, int signo, void *sival_ptr)
 #else
   dbg("TCB=0x%08x signo=%d value=%p\n", stcb, signo, sival_ptr);
 #endif
+  if (pid == 0 || !stcb)
+    {
+      *get_errno_ptr() = ESRCH;
+      sched_unlock();
+      return ERROR;
+    }
 
   /* Create the siginfo structure */
 
@@ -129,15 +152,9 @@ int sigqueue(int pid, int signo, void *sival_ptr)
   info.si_value.sival_ptr = sival_ptr;
 #endif
 
-  /* Verify that we can perform the signalling operation */
-
-  if (stcb && GOOD_SIGNO(signo))
-    {
-      /* Process the receipt of the signal */
-
-      ret = sig_received(stcb, &info);
-    }
+  /* Send the signal */
 
+  ret = sig_received(stcb, &info);
   sched_unlock();
   return ret;
 }