nuttx/nuttx-update
1
2
Fork 1
Code Issues 1 Pull requests 1 Projects Releases Packages Wiki Activity Actions

fs/inode: refresh tcb after each file sync() is completed

Browse source 
After tcb is destroyed, it is very dangerous to back reference tcb through file.
This commit will perform file operations while ensuring the validity of tcb during
fsync, with will avoid tcb check in each subsystem.

Signed-off-by: chao an <anchao@lixiang.com>
This commit is contained in:
chao an 2024-10-22 13:26:41 +08:00 committed by Xiang Xiao
parent e4705e7f62
commit b99e7617aa
1 changed files with 20 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
fs/inode/fs_files.c
View file

@ -208,32 +208,43 @@ static int files_extend(FAR struct filelist *list, size_t row)
static void task_fssync(FAR struct tcb_s *tcb, FAR void *arg)
{
FAR struct filelist *list;
FAR struct tcb_s *ctcb;
FAR struct file *filep;
int pid = tcb->pid;
uint8_t rows;
int i;
int j;
list = files_getlist(tcb);
if (list == NULL)
if (tcb->group == NULL)
{
return;
}
for (i = 0; i < list->fl_rows; i++)
rows = tcb->group->tg_filelist.fl_rows;
for (i = 0; i < rows; i++)
{
for (j = 0; j < CONFIG_NFILE_DESCRIPTORS_PER_BLOCK; j++)
{
FAR struct file *filep;
ctcb = nxsched_get_tcb(pid);
if (ctcb == NULL || ctcb->group == NULL || ctcb != tcb)
{
return;
}
filep = files_fget_by_index(list, i, j, NULL);
filep = files_fget_by_index(&ctcb->group->tg_filelist,
i, j, NULL);
if (filep != NULL)
{
file_fsync(filep);
fs_putfilep(filep);
ctcb = nxsched_get_tcb(pid);
if (ctcb != NULL && ctcb->group != NULL && ctcb == tcb)
{
fs_putfilep(filep);
}
}
}
}
files_putlist(list);
}
/****************************************************************************