nuttx/nuttx-update
1
2
Fork 1
Code Issues 1 Pull requests 1 Projects Releases Packages Wiki Activity Actions

driver/serial: Only enable tx interrupt if tx buffer is not empty

Browse source 
Fix https://github.com/apache/nuttx/issues/8731

Signed-off-by: Huang Qi <huangqi3@xiaomi.com>
This commit is contained in:
Huang Qi 2023-03-08 15:10:41 +08:00 committed by Petro Karashchenko
parent 47ce89f757
commit cfe6c4be8e
1 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
drivers/serial/serial.c
View file

@ -776,6 +776,7 @@ static ssize_t uart_read(FAR struct file *filep,
#endif
irqstate_t flags;
ssize_t recvd = 0;
bool echoed = false;
int16_t tail;
char ch;
int ret;
@ -924,6 +925,13 @@ static ssize_t uart_read(FAR struct file *filep,
}
uart_putxmitchar(dev, ch, true);
/* Mark the tx buffer have echoed content here,
* to avoid the tx buffer is empty such as special escape
* sequence received, but enable the tx interrupt.
*/
echoed = true;
}
/* Skipping character count down */
@ -1116,7 +1124,7 @@ static ssize_t uart_read(FAR struct file *filep,
}
}
if (recvd > 0)
if (echoed)
{
#ifdef CONFIG_SERIAL_TXDMA
uart_dmatxavail(dev);