nuttx/nuttx-update
1
2
Fork 1
Code Issues 1 Pull requests 1 Projects Releases Packages Wiki Activity Actions

sched/environ: check envcp validity before hold sched_lock()

Browse source 
check envcp validity before hold sched_lock() to avoid unnecessary schedule lock

Signed-off-by: chao an <anchao@lixiang.com>
This commit is contained in:
chao an 2024-03-05 10:39:27 +08:00 committed by Xiang Xiao
parent 73c4f2f1e7
commit dfd1e38b40
1 changed files with 8 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
sched/environ/env_dup.c
View file

@ -70,16 +70,16 @@ int env_dup(FAR struct task_group_s *group, FAR char * const *envcp)
DEBUGASSERT(group != NULL); DEBUGASSERT(group != NULL);
/* Pre-emption must be disabled throughout the following because the
* environment may be shared.
*/
sched_lock();
/* Is there an environment ? */ /* Is there an environment ? */
if (envcp != NULL) if (envcp != NULL)
{ {
/* Pre-emption must be disabled throughout the following because the
* environment may be shared.
*/
sched_lock();
/* Count the strings */ /* Count the strings */
while (envcp[envc] != NULL) while (envcp[envc] != NULL)
@ -138,9 +138,10 @@ int env_dup(FAR struct task_group_s *group, FAR char * const *envcp)
/* Save the child environment allocation. */ /* Save the child environment allocation. */
group->tg_envp = envp; group->tg_envp = envp;
sched_unlock();
} }
sched_unlock();
return ret; return ret;
} }