nuttx/nuttx-update
1
2
Fork 1
Code Issues 1 Pull requests 1 Projects Releases Packages Wiki Activity Actions

max32660_rtc: use small lock in arch/arm/src/max326xx/max32660/max32660_rtc.c

Browse source 
reason:
We hope to remove all instances of spin_lock_irqsave(NULL).

Signed-off-by: hujun5 <hujun5@xiaomi.com>
This commit is contained in:
hujun5 2024-12-09 21:15:52 +08:00 committed by Xiang Xiao
parent 6b7722cfb4
commit ecab220c39
1 changed files with 8 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
arch/arm/src/max326xx/max32660/max32660_rtc.c
View file

@ -80,6 +80,8 @@ static alm_callback_t g_alarmcb;
static void *g_alarmarg; static void *g_alarmarg;
#endif #endif
static spinlock_t lock = SP_UNLOCKED;
/**************************************************************************** /****************************************************************************
* Public Data * Public Data
****************************************************************************/ ****************************************************************************/
@ -459,7 +461,7 @@ int up_rtc_settime(const struct timespec *tp)
/* Enable write access to RTC configuration registers */ /* Enable write access to RTC configuration registers */
flags = spin_lock_irqsave(NULL); flags = spin_lock_irqsave(&lock);
max326_rtc_wrenable(true); max326_rtc_wrenable(true);
/* We need to disable the RTC in order to write to the SEC and SSEC /* We need to disable the RTC in order to write to the SEC and SSEC
@ -483,7 +485,7 @@ int up_rtc_settime(const struct timespec *tp)
max326_rtc_enable(true); max326_rtc_enable(true);
max326_rtc_wrenable(false); max326_rtc_wrenable(false);
spin_unlock_irqrestore(NULL, flags); spin_unlock_irqrestore(&lock, flags);
return OK; return OK;
} }
@ -522,7 +524,7 @@ int max326_rtc_setalarm(struct timespec *ts,
/* Is there already something waiting on the ALARM? */ /* Is there already something waiting on the ALARM? */
flags = spin_lock_irqsave(NULL); flags = spin_lock_irqsave(&lock);
if (g_alarmcb == NULL) if (g_alarmcb == NULL)
{ {
/* Get the time as a fixed precision number. /* Get the time as a fixed precision number.
@ -617,7 +619,7 @@ int max326_rtc_setalarm(struct timespec *ts,
} }
errout_with_lock: errout_with_lock:
spin_unlock_irqrestore(NULL, flags); spin_unlock_irqrestore(&lock, flags);
return ret; return ret;
} }
#endif #endif
@ -717,7 +719,7 @@ int max326_rtc_cancelalarm(void)
uint32_t regval; uint32_t regval;
int ret = -ENODATA; int ret = -ENODATA;
flags = spin_lock_irqsave(NULL); flags = spin_lock_irqsave(&lock);
if (g_alarmcb != NULL) if (g_alarmcb != NULL)
{ {
@ -745,7 +747,7 @@ int max326_rtc_cancelalarm(void)
ret = OK; ret = OK;
} }
spin_unlock_irqrestore(NULL, flags); spin_unlock_irqrestore(&lock, flags);
return ret; return ret;
} }
#endif #endif